Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UA-9902): rollback the null tracking id change #911

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

AdamMartineau-Coveo
Copy link
Contributor

@AdamMartineau-Coveo AdamMartineau-Coveo commented Feb 17, 2025

Acceptance Criteria

Trying to update the platform-client version in the UI uncovered a issue, given this is such a small change I prefer to roll it back in the mean time as to not block the project.

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@AdamMartineau-Coveo AdamMartineau-Coveo marked this pull request as ready for review February 17, 2025 18:39
@AdamMartineau-Coveo AdamMartineau-Coveo requested a review from a team as a code owner February 17, 2025 18:39
Copy link
Contributor

@paulgerold paulgerold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AdamMartineau-Coveo AdamMartineau-Coveo added this pull request to the merge queue Feb 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2025
@AdamMartineau-Coveo AdamMartineau-Coveo changed the title feat:(UA-9902): rollback the null tracking id change feat(UA-9902): rollback the null tracking id change Feb 17, 2025
@AdamMartineau-Coveo AdamMartineau-Coveo added this pull request to the merge queue Feb 17, 2025
Merged via the queue into master with commit 2c82321 Feb 17, 2025
14 checks passed
@AdamMartineau-Coveo AdamMartineau-Coveo deleted the fix/UA-9902-rollback-null-tracking-id branch February 17, 2025 19:04
Copy link

🎉 This PR is included in version 58.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants